Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )
Change subject: [ranger] Use unique loopback for MiniRanger ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/postgres/mini_postgres.h File src/kudu/postgres/mini_postgres.h: http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/postgres/mini_postgres.h@40 PS2, Line 40: : MiniPostgres(GetTestDataDirectory(), std::move(host)) {} > warning: parameter 'host' is passed by value and only copied once; consider Done http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h File src/kudu/ranger/mini_ranger.h: http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h@67 PS2, Line 67: : MiniRanger(GetTestDataDirectory(), std::move(host)) {} > warning: parameter 'host' is passed by value and only copied once; consider Done http://gerrit.cloudera.org:8080/#/c/15625/2/src/kudu/ranger/mini_ranger.h@74 PS2, Line 74: mini_pg_(data_root_, host_), > warning: Moved-from object 'host' of type 'std::basic_string' is copied [cl Done -- To view, visit http://gerrit.cloudera.org:8080/15625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0 Gerrit-Change-Number: 15625 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 01 Apr 2020 12:02:51 +0000 Gerrit-HasComments: Yes
