Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15044 )
Change subject: cfile: clean up encoding-test to use fewer templates ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15044/3/src/kudu/cfile/type_encodings.h File src/kudu/cfile/type_encodings.h: PS3: > Oops, yea. I took a peek at it, changing the signature of functions in this interface would entail changing function pointers and what appears bunch of templatized specialization for encodings. It's best done separately as a follow-up change. http://gerrit.cloudera.org:8080/#/c/15044/3/src/kudu/cfile/type_encodings.h@53 PS3, Line 53: // iter parameter will only be used when it is dictionary encoding > nit: not your fault, but could you update this to mention that this is an i Done -- To view, visit http://gerrit.cloudera.org:8080/15044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a Gerrit-Change-Number: 15044 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 08 Apr 2020 22:11:28 +0000 Gerrit-HasComments: Yes
