Bankim Bhavsar has uploaded a new patch set (#4) to the change originally 
created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/15044 )

Change subject: cfile: clean up encoding-test to use fewer templates
......................................................................

cfile: clean up encoding-test to use fewer templates

This test made heavy use of templates, which made things overly
complicated and hard to follow. All of the block builders/decoders
already implement common interfaces, so we can use runtime polymorphism
instead for the majority of code here.

Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
5 files changed, 270 insertions(+), 320 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15044/4
--
To view, visit http://gerrit.cloudera.org:8080/15044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a
Gerrit-Change-Number: 15044
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to