Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15784 )
Change subject: [www] convert human-readable int to int when compare numeric strings ...................................................................... Patch Set 1: (3 comments) > Patch Set 1: > > So for something like 10GB v/s 100MB, 10GB looks larger with number of > digits, right? > Personally I don't see a need for this unless the output will be fed to a > `sort` utility. But this is GUI so there is no such expectation. > > Perhaps you could link screenshots to make the case for this change. Some tables in the UI are sortable as of 1.12. http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js@56 PS1, Line 56: val = parseFloat(humanReadableNum); Don't we need to substring this like we do above? http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js@60 PS1, Line 60: if (end == 'k') { Nit: consider a switch like in toNumBytes()? http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js@68 PS1, Line 68: } else if (isNaN(end)) { Nit: could you comment why we are stopping here, rather than going above with Q and beyond? -- To view, visit http://gerrit.cloudera.org:8080/15784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e832beb0dfdf5c2162bf0e9faeb3d0d0d737cd Gerrit-Change-Number: 15784 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 23 Apr 2020 02:15:51 +0000 Gerrit-HasComments: Yes
