Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15784 )
Change subject: [www] convert human-readable int to int when compare numeric strings ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: Code-Review+2 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/15784/1/www/kudu.js@56 PS1, Line 56: val = parseFloat(humanReadableNum); > I see, and it looks like parseFloat() actually ignores any trailing non-num Yes. https://www.w3schools.com/jsref/jsref_parsefloat.asp -- To view, visit http://gerrit.cloudera.org:8080/15784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e832beb0dfdf5c2162bf0e9faeb3d0d0d737cd Gerrit-Change-Number: 15784 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 03:50:21 +0000 Gerrit-HasComments: Yes
