Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15790 )
Change subject: tablet: set up RowSetKeyProbe fields in initialization list ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15790/1/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/15790/1/src/kudu/tablet/rowset.h@319 PS1, Line 319: explicit > explicit no longer needed, right? still needed because it has only a single argument and we don't want it to be an implicit type conversion constructor -- To view, visit http://gerrit.cloudera.org:8080/15790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe46e00f5ca8c13c7366df4bee04e7c6e840b3a0 Gerrit-Change-Number: 15790 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 23 Apr 2020 20:03:09 +0000 Gerrit-HasComments: Yes
