Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15790 )
Change subject: tablet: set up RowSetKeyProbe fields in initialization list ...................................................................... tablet: set up RowSetKeyProbe fields in initialization list For some reason, setting these fields in the body of the constructor generated a lot more code than setting them in the constructor list. Namely, the setting of a unique_ptr<> generated a check whether the pointer was already set, and code to deallocate the old version if it was. I'm not sure why clang couldn't figure out that it couldn't possibly be set -- perhaps something to do with inheritance (eg maybe a subclass would have set the field in its constructor before chaining upwards?). Either way, this was taking 2-3% CPU and dropped after this change. Change-Id: Ibe46e00f5ca8c13c7366df4bee04e7c6e840b3a0 Reviewed-on: http://gerrit.cloudera.org:8080/15790 Reviewed-by: Bankim Bhavsar <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/tablet/rowset.h 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Bankim Bhavsar: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibe46e00f5ca8c13c7366df4bee04e7c6e840b3a0 Gerrit-Change-Number: 15790 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]>
