Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15788 )
Change subject: client: fix extra construction of ColumnSchema ...................................................................... client: fix extra construction of ColumnSchema The VARCHAR patches introduced a line 'auto col = schema.column(idx)' which ends up making a copy of the ColumnSchema object instead of taking a reference to it. This is unnecessary and quite slow. This shows up as a significant CPU consumer when running tpch_real_world insert workload. Change-Id: Iafae805979495e7e15c5294a317d6e00255654e0 Reviewed-on: http://gerrit.cloudera.org:8080/15787 Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Kudu Jenkins (cherry picked from commit 9c5d8c97915376de4fb6027a3f73d00e160fd1d7) Reviewed-on: http://gerrit.cloudera.org:8080/15788 Reviewed-by: Alexey Serbin <aser...@cloudera.com> Tested-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Hao Hao <hao....@cloudera.com> --- M src/kudu/common/partial_row.cc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, but someone else must approve; Verified Hao Hao: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: merged Gerrit-Change-Id: Iafae805979495e7e15c5294a317d6e00255654e0 Gerrit-Change-Number: 15788 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
