Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15788 )
Change subject: client: fix extra construction of ColumnSchema ...................................................................... Patch Set 1: Code-Review+2 > Patch Set 1: > > I dunno, I think known regressions with trivial fixes should be included. If > this were a perf optimization (not a regression) I would completely agree, > but I think this could reduce ingest performance by 5-10% for some workloads I see, sounds good to me. -- To view, visit http://gerrit.cloudera.org:8080/15788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: Iafae805979495e7e15c5294a317d6e00255654e0 Gerrit-Change-Number: 15788 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 23 Apr 2020 20:52:30 +0000 Gerrit-HasComments: No
