Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/15758/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15758/7//COMMIT_MSG@15 PS7, Line 15: partitiong partitioning http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@867 PS7, Line 867: Schema schema({ ColumnSchema("k", INT32) }, nit: add 'const' if it's not going to change in this scenario? http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@412 PS7, Line 412: int nit: auto ? http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@414 PS7, Line 414: vector<HashBucketSchema> nit: maybe, use auto? http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@429 PS7, Line 429: new_partitions.push_back(partition); nit: does it make sense to use emplace_back(std::move(partion)) here? http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@432 PS7, Line 432: all_hash_partitions.swap(new_partitions); Is std::move() any better here or that's the same? all_hash_partitions = std::move(new_partitions); -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Apr 2020 06:23:18 +0000 Gerrit-HasComments: Yes
