Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@415 PS7, Line 415: // Copy all partitions created in the begin of the function > nit: I think we can be a bit more descriptive with what we're doing here, m Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@419 PS7, Line 419: // Create a partition per range bound and hash bucket combination. > nit: maybe, "Combine each bucket from this bucket schema with every partiti Done -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 8 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Tue, 05 May 2020 19:02:19 +0000 Gerrit-HasComments: Yes