Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15850 )
Change subject: KUDU-3113: fix auto-rebalancer move execution ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15850/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15850/2//COMMIT_MSG@18 PS2, Line 18: blet server, > maintenance Done http://gerrit.cloudera.org:8080/#/c/15850/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15850/2/src/kudu/master/auto_rebalancer-test.cc@329 PS2, Line 329: AggregateMetricCounts(GetBytesSentByTServer(), 0, kNumTServers); > nit: add const to be explicit that the value is not to change during the sc Done http://gerrit.cloudera.org:8080/#/c/15850/2/src/kudu/master/auto_rebalancer-test.cc@457 PS2, Line 457: AggregateMetricCounts(GetBytesSentByTServer(), 0, kNumOrigTservers); > nit: add const ? Done http://gerrit.cloudera.org:8080/#/c/15850/2/src/kudu/master/auto_rebalancer-test.cc@515 PS2, Line 515: AggregateMetricCounts(GetBytesSentByTServer(), 0, kNumTServers); > nit: add const? Done -- To view, visit http://gerrit.cloudera.org:8080/15850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15850 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 May 2020 02:37:39 +0000 Gerrit-HasComments: Yes
