Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15850 )
Change subject: KUDU-3113: fix auto-rebalancer move execution ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15850/4/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/15850/4/src/kudu/master/auto_rebalancer-test.cc@575 PS4, Line 575: SleepFor(MonoDelta::FromSeconds( : FLAGS_follower_unavailable_considered_failed_sec)); : ASSERT_OK(cluster_->AddTabletServer()); Is there any significance if adding follower_unavailable_considered_failed_sec pause before adding a new tablet server? Is that to verify that the auto-rebalancer will not do anything unexpected even after the re-replication starts in the background? Maybe, it's worth adding a small comment clarifying on that? Feel free to ignore, though. -- To view, visit http://gerrit.cloudera.org:8080/15850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If658997dc9bcb709c27d981db56cf2db13ba235f Gerrit-Change-Number: 15850 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 May 2020 17:40:59 +0000 Gerrit-HasComments: Yes
