Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16067 )
Change subject: KUDU-3148: [test] Add Java client metrics ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/16067/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16067/7//COMMIT_MSG@12 PS7, Line 12: exanded > nit: expanded Done http://gerrit.cloudera.org:8080/#/c/16067/7//COMMIT_MSG@25 PS7, Line 25: > nit: drop extra space Done http://gerrit.cloudera.org:8080/#/c/16067/7/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java: http://gerrit.cloudera.org:8080/#/c/16067/7/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@455 PS7, Line 455: final Connection connection, : f > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/16067/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduMetrics.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduMetrics.java: http://gerrit.cloudera.org:8080/#/c/16067/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduMetrics.java@68 PS7, Line 68: } > Do you think it's worth disabling and verifying the empty metrics at this p Sure, can't hurt. -- To view, visit http://gerrit.cloudera.org:8080/16067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018 Gerrit-Change-Number: 16067 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Jun 2020 04:03:18 +0000 Gerrit-HasComments: Yes
