Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16067 )
Change subject: KUDU-3148: [test] Add Java client metrics ...................................................................... KUDU-3148: [test] Add Java client metrics This patch adds the basic tools for instrumenting the Java Kudu client with metrics. The primary purpose for this patch is greater visibility and validation in tests. However, it leverages micrometer for the metrics to allow for expanded usage and use cases in the future (e.g JMX publishing, periodic diagnostic logging, etc). In this patch I add some counter metrics for RPC requests, retries, and responses. I leverage these metrics in TestScanToken to validate the current behavior of ScanToken generation and use. A follow on patch will use these metrics more to validate improvements to the ScanToken. I did not use or enhance the existing Statistics.java implementation because it didn’t appear to be flexible and powerful enough for general purpose metrics without a lot of work (effectively writing something like micrometer). Outside of the additional work, Statistics.java is public API which makes it more difficult to change. Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018 Reviewed-on: http://gerrit.cloudera.org:8080/16067 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M java/gradle/dependencies.gradle M java/kudu-client/build.gradle M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java A java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduMetrics.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java A java/kudu-test-utils/src/main/java/org/apache/kudu/test/MetricTestUtils.java 10 files changed, 508 insertions(+), 3 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018 Gerrit-Change-Number: 16067 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
