Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 )
Change subject: KUDU-2612 p6: add coordination calls to system client ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/client/batcher.cc@509 PS1, Line 509: // TODO: This error handling block should really be rewritten to handle > warning: missing username/bug in TODO [google-readability-todo] Ack http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/integration-tests/txn_status_table-itest.cc@214 PS1, Line 214: KuduTest::SetUp(); > warning: qualified name 'KuduTest::SetUp' refers to a member overridden in Ack http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc File src/kudu/transactions/coordinator_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc@44 PS1, Line 44: using kudu::client::internal::RemoteTabletServer; > warning: using decl 'RemoteTablet' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc@47 PS1, Line 47: using kudu::rpc::CredentialsPolicy; > warning: using decl 'KuduTable' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc@54 PS1, Line 54: using strings::Substitute; > warning: using decl 'CoordinatorOpPB' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc@55 PS1, Line 55: > warning: using decl 'CoordinateTransactionRequestPB' is unused [misc-unused Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/coordinator_rpc.cc@56 PS1, Line 56: namespace kudu { > warning: using decl 'CoordinateTransactionResponsePB' is unused [misc-unuse Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/txn_system_client.cc@52 PS1, Line 52: using kudu::tserver::CoordinatorOpPB; > warning: using decl 'CoordinateTransactionRequestPB' is unused [misc-unused Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/txn_system_client.cc@151 PS1, Line 151: const MonoTime deadline = MonoTime::Now() + timeout; > warning: the parameter 'cb' is copied for each invocation but only used as Done http://gerrit.cloudera.org:8080/#/c/16194/1/src/kudu/transactions/txn_system_client.cc@186 PS1, Line 186: rpc->SendRpc(); > warning: std::move of the const variable 'cb' has no effect; remove std::mo Done -- To view, visit http://gerrit.cloudera.org:8080/16194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4126cb3dcf379b397f84578c2265dca3ece3d98c Gerrit-Change-Number: 16194 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jul 2020 08:00:19 +0000 Gerrit-HasComments: Yes
