Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 )
Change subject: KUDU-2612 p6: add coordination calls to system client ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16194/3/src/kudu/transactions/txn_system_client.h File src/kudu/transactions/txn_system_client.h: http://gerrit.cloudera.org:8080/#/c/16194/3/src/kudu/transactions/txn_system_client.h@79 PS3, Line 79: MonoDelta timeout > Done I haven't found an elegant way to convert client::sp::shared_ptr<> to std::shared_ptr<>. it seems std::tr1::shared_ptr<> doesn't have release() or move semantics, so I've reverted for now. I haven't seen this in our codebase -- have you seen this conversion work elsewhere? -- To view, visit http://gerrit.cloudera.org:8080/16194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4126cb3dcf379b397f84578c2265dca3ece3d98c Gerrit-Change-Number: 16194 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 29 Jul 2020 01:30:29 +0000 Gerrit-HasComments: Yes
