Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16193 )
Change subject: KUDU-2612 p5: RPC endpoints for txn status management ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1033 PS1, Line 1033: static CreateTabletRequestPB CreateTxnTabletReq(const string& tablet_id, const string& replica_id, > warning: method 'CreateTxnTabletReq' can be made static [readability-conver Done http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1078 PS1, Line 1078: > warning: method 'StartTransactions' can be made static [readability-convert Done http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1089 PS1, Line 1089: > warning: method 'CreateCoordinateTxnReq' can be made static [readability-co Done http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16193/1/src/kudu/tserver/tablet_service.cc@1172 PS1, Line 1172: Status ValidateCoordinatorOpFields(const CoordinatorOpPB& op) { > warning: the const qualified parameter 'op' is copied for each invocation; Done -- To view, visit http://gerrit.cloudera.org:8080/16193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id846160724b334d2c52eb9a1bae0ffd19536bcc9 Gerrit-Change-Number: 16193 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jul 2020 08:00:16 +0000 Gerrit-HasComments: Yes
