Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16193 )
Change subject: KUDU-2612 p5: RPC endpoints for txn status management ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1217 PS3, Line 1217: TestTabletServerProxyCallErrors What about a scenario when non-admin/non-service user credentials are used to issue those calls? http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/tserver/tablet_service.cc@1267 PS3, Line 1267: // TODO(awong): once transactions are useable, add a feature flag. What's the reason to postpone that till the time when transactions are usable? Would it become non-functional code if doing it now? Also, do you think there will be just one feature flag related to the transaction-related functionality, or you plan to have multiples here due to multiple stages of rolling out the transaction functionality? http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/16193/3/src/kudu/tserver/tserver_admin.proto@50 PS3, Line 50: // TODO(awong): populate this with some application-level results, like the : // actual transaction ID assigned, the next highest transaction ID available, : // etc. Indeed. Do you think it's necessary to do so in this iteration of the patch or you are planning to post a follow-up patch with those? -- To view, visit http://gerrit.cloudera.org:8080/16193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id846160724b334d2c52eb9a1bae0ffd19536bcc9 Gerrit-Change-Number: 16193 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 Jul 2020 19:19:48 +0000 Gerrit-HasComments: Yes
