Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 )
Change subject: [maintenance] use workload statistics to scale perf_improvement ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.h@470 PS9, Line 470: // Return the current workload score of the tablet. > Can you also mention that this isn't thread-safe and should only be called Done http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.h@777 PS9, Line 777: // ensures we do not attempt to collect metrics while calling the destructor. : FunctionGaugeDetacher metric_detacher_; : : MonoTime last_update_workload_stats_time_; : int64_t last_scans_started_; : int64_t last_rows_inserted_; : int64_t last_rows_upserted_; : int64_t last_rows_updated_; > It seems we're that these are all mutable and that CollectAndUpdateWorkload Done http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.cc@175 PS9, Line 175: Minimum write rate for tablets to be considered > nit: Minimum write rate for tablets to be considered 'hot'" Done http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.cc@176 PS9, Line 176: rate exceeds this valu > nit: "rate exceeds this value" Done http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.cc@176 PS9, Line 176: it will be assigned the h > nit: "...it will be assigned the highest possible workload score, which is. Done http://gerrit.cloudera.org:8080/#/c/15995/9/src/kudu/tablet/tablet.cc@176 PS9, Line 176: op > nit: we lowercase "op" in other flag descriptions, so just "ops"? Done http://gerrit.cloudera.org:8080/#/c/15995/7/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/15995/7/src/kudu/tablet/tablet_mm_ops.cc@86 PS7, Line 86: ten > Did you add this change? I don't see it in PS9 Sorry, I tested this in real cluster but forgot to add a test. -- To view, visit http://gerrit.cloudera.org:8080/15995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3afcc359002d1392164ba2fda885f8930ef8696 Gerrit-Change-Number: 15995 Gerrit-PatchSet: 10 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2020 18:30:11 +0000 Gerrit-HasComments: Yes
