Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15995 )
Change subject: [maintenance] use workload statistics to scale perf score of flushes/compactions ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/tserver/tablet_server-test.cc@4291 PS12, Line 4291: FLAGS_enable_maintenance_manager = true; : NO_FATALS(ShutdownAndRebuildTablet()); : : / > nit: for future reference, this also exists as a macro Done http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/tserver/tablet_server-test.cc@4335 PS12, Line 4335: }); > Could we wait for much shorter, maybe 5 seconds, to prove the same thing? I Thanks for your suggestions! I improved the test according to it. http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/util/maintenance_manager-test.cc@557 PS12, Line 557: op5.set_perf_improvement(12); : op5.set_remaining_runs(1); : op5.set_sleep_time(MonoDelta::FromMilliseconds(1)); : : TestMaintenanceOp op6("op6", MaintenanceOp::HIGH_IO > Do we have a test anywhere that we don't run ops that have a perf score of Not yet, I will add one. http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/15995/12/src/kudu/util/maintenance_manager.cc@425 PS12, Line 425: AdjustedPerfSco > nit: it's getting a bit difficult to track which perf score is which. Would Done -- To view, visit http://gerrit.cloudera.org:8080/15995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3afcc359002d1392164ba2fda885f8930ef8696 Gerrit-Change-Number: 15995 Gerrit-PatchSet: 13 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2020 12:32:12 +0000 Gerrit-HasComments: Yes
