Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 )
Change subject: KUDU-2612 p6: add coordination calls to system client ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc File src/kudu/integration-tests/auth_token_expire-itest.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc@470 PS6, Line 470: ASSERT_OK(txn_client->OpenTxnStatusTable()); > The BeginTransaction() call is the first connection made to the tablet serv Yes, if the BeginTransaction() makes an RPC to a tablet server, while OpenTxnStatusTable() made one to master, it makes sense. Thank you for the clarification. Do you think it might be useful adding a comment explaining the destination of OpenTxnStatusTable() and BeginTransaction() calls? From the other side, looking at this test scenario again, I realized what bothered me here. Do we have a coverage for the case when first txn_client->OpenTxnStatusTable() is called, then the cluster is restarted, and the txn_client->BeginTransaction() call is attempted? Will that succeed as expected? -- To view, visit http://gerrit.cloudera.org:8080/16194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4126cb3dcf379b397f84578c2265dca3ece3d98c Gerrit-Change-Number: 16194 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 03 Aug 2020 01:49:58 +0000 Gerrit-HasComments: Yes
