Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16194 )
Change subject: KUDU-2612 p6: add coordination calls to system client ...................................................................... Patch Set 6: (7 comments) mostly nits http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc File src/kudu/integration-tests/auth_token_expire-itest.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/auth_token_expire-itest.cc@470 PS6, Line 470: ASSERT_OK(txn_client->OpenTxnStatusTable()); If thinking about resetting all connection and re-acquiring the authn token, shouldn't this be moved to happen after SleepFor() below? http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/txn_status_table-itest.cc@426 PS6, Line 426: for (int t = 0; t < 2; t++) { : threads.emplace_back([&, t] { : for (int i = 0; i < 10; i++) { : int64_t txn_id = t * 10 + i; Would this need some update once transaction ID ordering becomes important -- i.e., once BeginTransaction(X) has been successfully called, should calling BeginTransaction(X - 1) return an error? http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/txn_status_table-itest.cc@430 PS6, Line 430: ASSERT_OK Does this work as expected when the underlying operation returns non-OK status? http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/integration-tests/txn_status_table-itest.cc@532 PS6, Line 532: to drop http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/tablet/txn_coordinator.h File src/kudu/tablet/txn_coordinator.h: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/tablet/txn_coordinator.h@46 PS6, Line 46: Starts a transaction with the given ID as the given user Here and below: does it worth documenting the 'ts_error' output parameter? http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/transactions/txn_system_client.cc@177 PS6, Line 177: First, take ownership of the context. Why not to use unique_ptr<TxnStatusTabletContext> ctx_x(ctx.release()) here instead of the dance with ctx_raw and ignore_result(ctx.release()) before returning? http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16194/6/src/kudu/tserver/tablet_service.cc@1231 PS6, Line 1231: need be nit: needed ? -- To view, visit http://gerrit.cloudera.org:8080/16194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4126cb3dcf379b397f84578c2265dca3ece3d98c Gerrit-Change-Number: 16194 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 31 Jul 2020 02:28:39 +0000 Gerrit-HasComments: Yes
