Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16340/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16340/1//COMMIT_MSG@15 PS1, Line 15: Inorder > nit: In order Done http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options-test.cc@57 PS1, Line 57: class MasterOptionsTest : public KuduTest { : }; > Yea those would be good validations to add. Re: forward compatibility ie. older code reading Raft config persisted by newer code. Most code I see checks for presence of 'last_known_addr' field and uses it if present. So mostly looks okay. One hypothetical case, after the master is downgraded and operator decides to change the hostname of the master. In that case there'll be discrepancy between the Raft persisted config and the hostname the master is running at. This is okay as long as the master remains in single master config. In older code, the Raft config will need to be manually updated to migrate to multiple masters. If the master is subsequently upgraded and --master_addresses supplied is different then as per new validations in PS2, master will not come up. Manually updating the Raft config using CLI tool would be one option. http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options.h File src/kudu/master/master_options.h: http://gerrit.cloudera.org:8080/#/c/16340/1/src/kudu/master/master_options.h@40 PS1, Line 40: NOT_FOUND > nit: we usually refer to Status errors in TitleCase Done -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 19:18:50 +0000 Gerrit-HasComments: Yes
