Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16340/2/src/kudu/master/master_options-test.cc File src/kudu/master/master_options-test.cc: http://gerrit.cloudera.org:8080/#/c/16340/2/src/kudu/master/master_options-test.cc@181 PS2, Line 181: SetMasterAddresses How about the case where there's a single master on disk and multiple supplied? I imagine that being the case for when a user wants to add a master. Will a single master currently fail? http://gerrit.cloudera.org:8080/#/c/16340/2/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/16340/2/src/kudu/master/sys_catalog.cc@276 PS2, Line 276: RETURN_NOT_OK(consensus::VerifyRaftConfig(cstate.committed_config())); Shouldn't we verify this before flushing to disk? -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 28 Aug 2020 19:22:15 +0000 Gerrit-HasComments: Yes
