Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16420 )
Change subject: KUDU-2884: [hms] Improve master address matching ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16420/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/16420/3/src/kudu/tools/kudu-tool-test.cc@4091 PS3, Line 4091: // Test case: orphan table in the HMS with different, but functionally : // the same master addresses. Do you mind adding a 'negative' case here as well, so the set of master addresses would contain addresses that differ at * actual addresses, but still having the same port numbers (or a combination of omitted port numbers) * actual port numbers, but maybe still having same hostnames ? http://gerrit.cloudera.org:8080/#/c/16420/3/src/kudu/tools/kudu-tool-test.cc@4103 PS3, Line 4103: LOG(INFO) << "Modified Masters: " << JoinStrings(modified_addrs, ","); If this was added just for debugging purposes, maybe it's possible to drop this now when the test is ready? http://gerrit.cloudera.org:8080/#/c/16420/3/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/16420/3/src/kudu/tools/tool_action_common.cc@571 PS3, Line 571: UnorderedHostPortSet* res I'm not sure I understand how the 'res' parameter is used in this function aside from calling 'res->clear()' at line 572. Do I miss something? -- To view, visit http://gerrit.cloudera.org:8080/16420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00059ff1b5134f7e5d6ea8be4fdf0701aa56b0c7 Gerrit-Change-Number: 16420 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Sep 2020 01:55:01 +0000 Gerrit-HasComments: Yes
