Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16420 )
Change subject: KUDU-2884: [hms] Improve master address matching ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16420/6/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/16420/6/src/kudu/tools/tool_action_common.cc@578 PS6, Line 578: for (auto hp : hp_vector) { : res->emplace(std::move(hp)); : } Nit: res->insert(hp_vector.begin(), hp_vector.end()) -- To view, visit http://gerrit.cloudera.org:8080/16420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00059ff1b5134f7e5d6ea8be4fdf0701aa56b0c7 Gerrit-Change-Number: 16420 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Sep 2020 18:19:11 +0000 Gerrit-HasComments: Yes
