Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16493 )
Change subject: KUDU-3192: [client] Expose the cluster ID in the client KuduTable ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16493/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16493/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1328 PS3, Line 1328: assertTrue(client.getClusterId().isEmpty()); : // Do something that will cause the client to connect to the cluster. : client.listTabletServers(); : assertFalse(client.getClusterId().isEmpty()); > nit: maybe assert the strings are equal? It is auto-generated server side and there isn't a great way to get it from the server (without using the RPC this is testing). http://gerrit.cloudera.org:8080/#/c/16493/3/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/16493/3/src/kudu/integration-tests/cluster_itest_util.h@465 PS3, Line 465: const MonoDelta& timeout, : std::string* cluster_id); > nit: spacing Done -- To view, visit http://gerrit.cloudera.org:8080/16493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f5a451aaa44834534d2387ee1c9aa9cf95dd37 Gerrit-Change-Number: 16493 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Sep 2020 20:31:58 +0000 Gerrit-HasComments: Yes
