Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16493 )
Change subject: KUDU-3192: [client] Expose the cluster ID in the client KuduTable ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16493/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16493/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1328 PS3, Line 1328: assertTrue(client.getClusterId().isEmpty()); : // Do something that will cause the client to connect to the cluster. : client.listTabletServers(); : assertFalse(client.getClusterId().isEmpty()); > It is auto-generated server side and there isn't a great way to get it from Ugh, I totally misread this test -- as you deduced I was referring to the cluster ID before the client even connected to the cluster, which I agree is fine to not test, given that's tested elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/16493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f5a451aaa44834534d2387ee1c9aa9cf95dd37 Gerrit-Change-Number: 16493 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Sep 2020 20:47:45 +0000 Gerrit-HasComments: Yes