Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/16560

to review the following change.


Change subject: tserver: only list tablets of user-defined tables by default
......................................................................

tserver: only list tablets of user-defined tables by default

Several tests depend on the fact that a cluster starts up with no
tablets. This will become a problem if we start creating the transaction
status table upon startup. So, in an effort to prevent such tests from
failing, this patch avoids listing system tables by default.

The optionality of the table_type() interface in TabletMetadata felt
needlessly clunky in implementing this, so I made the field non-optional
instead, opting to explicilty use DEFAULT_TABLE where appropriate. I
left the public constructors alone to avoid requiring common.pb.h in
every test that wanted to create a DEFAULT_TABLE tablet.

Change-Id: I3f8d34a8c377fcdef0162eaf042498a6d41baa4a
---
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
9 files changed, 88 insertions(+), 36 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/16560/1
--
To view, visit http://gerrit.cloudera.org:8080/16560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f8d34a8c377fcdef0162eaf042498a6d41baa4a
Gerrit-Change-Number: 16560
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>

Reply via email to