Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/16560 )
Change subject: [tserver] introduce filter_type for ListTablets ...................................................................... [tserver] introduce filter_type for ListTablets This patch adds 'filter_type' field into ListTabletsRequestPB. If the field is not set, it's interpreted as if the field were set to [DEFAULT_TABLE]. That's to return only user tables by default even if the transaction status table is present. By introducing such a behavior, this patch addresses the failure of 50+ tests when a transaction status table is created by TxnManager upon first startup of Kudu master (see the upcoming patch at https://gerrit.cloudera.org/#/c/16527). Those tests depend on the fact that a cluster starts up with no tablets. The optionality of the table_type() interface in TabletMetadata felt needlessly clunky in implementing this, so I made the field non-optional instead, opting to explicitly use DEFAULT_TABLE where appropriate. I left the public constructors alone to avoid requiring common.pb.h in every test that wanted to create a DEFAULT_TABLE tablet. Change-Id: I3f8d34a8c377fcdef0162eaf042498a6d41baa4a --- M src/kudu/integration-tests/txn_status_table-itest.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_replica.cc M src/kudu/tserver/mini_tablet_server.cc M src/kudu/tserver/mini_tablet_server.h M src/kudu/tserver/tablet_copy_client.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver.proto 10 files changed, 181 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/16560/2 -- To view, visit http://gerrit.cloudera.org:8080/16560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f8d34a8c377fcdef0162eaf042498a6d41baa4a Gerrit-Change-Number: 16560 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)