Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16510 )
Change subject: KUDU-2612: have MRS iteration account for txn metadata ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/mvcc-test.cc@817 PS4, Line 817: static void AbortBeforeBeginCommit(TxnMetadata* txn_meta) { > warning: method 'AbortBeforeBeginCommit' can be made static [readability-co Done http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/mvcc.h@416 PS4, Line 416: void ApplyOpUnlocked(Timestamp timestamp, > warning: function 'kudu::tablet::MvccManager::ApplyOpUnlocked' has a defini Done http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/txn_metadata.h File src/kudu/tablet/txn_metadata.h: http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/txn_metadata.h@37 PS4, Line 37: explicit TxnMetadata(bool aborted = false, > warning: constructors that are callable with a single argument must be mark Done http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/txn_participant.cc File src/kudu/tablet/txn_participant.cc: http://gerrit.cloudera.org:8080/#/c/16510/4/src/kudu/tablet/txn_participant.cc@146 PS4, Line 146: txns.emplace_back(txn_entry); > warning: std::move of the variable 'txn_entry' of the trivially-copyable ty Done -- To view, visit http://gerrit.cloudera.org:8080/16510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad Gerrit-Change-Number: 16510 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 09 Oct 2020 01:30:22 +0000 Gerrit-HasComments: Yes
