Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16510 )
Change subject: KUDU-2612: have MRS iteration account for txn metadata ...................................................................... Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@12 PS6, Line 12: TxnMetadata in the MRS Wondering is TxnMetadata and MRS is a 1 to 1 mapping? It seems so, by reading the code, but not sure why? Each MRS is only associate with one txn? http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@14 PS6, Line 14: relevancy Is relevancy is in terms of scan? http://gerrit.cloudera.org:8080/#/c/16510/6//COMMIT_MSG@35 PS6, Line 35: waiting waits http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset.h@367 PS6, Line 367: of nit: remove? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc@830 PS6, Line 830: MvccSnapshot initial_snap(initial_ts) IIUC, the initial snapshot type is kLatest, sorry I miss where in the test it is set to kTimestamp? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc.h@101 PS6, Line 101: If the commit MVCC op finished applying, the commit process is : // complete, Sorry, but I miss the part how do we make sure the mvcc op is not applied until the commit process finished? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h File src/kudu/tablet/txn_metadata.h: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h@84 PS6, Line 84: mutable simple_spinlock lock_; Can you add a comment on which resource the lock is protecting? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/txn_metadata.h@89 PS6, Line 89: commit_mvcc_op_timestamp_ If I understand correctly, this is BEGIN_COMMIT mvcc op? If so, do you think we should be clear about it somewhere in the comment? Either in the TxnMetadataPB or here? -- To view, visit http://gerrit.cloudera.org:8080/16510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad Gerrit-Change-Number: 16510 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 19 Oct 2020 06:57:19 +0000 Gerrit-HasComments: Yes
