Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 )
Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16581/4/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/16581/4/src/kudu/tablet/tablet_replica_mm_ops.cc@264 PS4, Line 264: FlushOpPerfImprovementPolicy::SetPerfImprovementForFlush( Nit: Perhaps update the docs in FlushOpPerfImprovementPolicy::SetPerfImprovementForFlush given its usage of `elapsed_time` is was based on time since flush and is now based on the time since the earliest dms. -- To view, visit http://gerrit.cloudera.org:8080/16581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id05202bf6a4685f4d79db11ef8ebb0f91f6316b4 Gerrit-Change-Number: 16581 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 13 Oct 2020 17:13:34 +0000 Gerrit-HasComments: Yes
