Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16581 to look at the new patch set (#6). Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold ...................................................................... KUDU-3195: flush when any DMS in the tablet is older than the time threshold Currently each tablet will wait at least 2 minutes (controlled by --flush_threshold_secs) between flushing DMSs, even if there are several DMSs that are older than 2 minutes in a given tablet. This means that for tablets with several dozen rowsets and updates across the entire tablet, it could take hours to flush all the deltas. Rather than waiting for 2 minutes since the last flush time before considering time-based flushing, this patch tracks the creation time of every DMS and flushes as long as there is a DMS that is older than 2 minutes in the tablet. Change-Id: Id05202bf6a4685f4d79db11ef8ebb0f91f6316b4 --- M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_replica_mm_ops.cc M src/kudu/tablet/tablet_replica_mm_ops.h M src/kudu/tserver/tablet_server-test.cc 14 files changed, 234 insertions(+), 150 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/16581/6 -- To view, visit http://gerrit.cloudera.org:8080/16581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id05202bf6a4685f4d79db11ef8ebb0f91f6316b4 Gerrit-Change-Number: 16581 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)