Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16586 )
Change subject: KUDU-2612: add TxnManager::BeginTransaction() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16586/2/src/kudu/master/txn_manager-test.cc File src/kudu/master/txn_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16586/2/src/kudu/master/txn_manager-test.cc@405 PS2, Line 405: static constexpr int64_t kNumTransactions = 10000; > nit: Would it also make sense to check that we have added several new table Good point! Done. http://gerrit.cloudera.org:8080/#/c/16586/2/src/kudu/master/txn_manager-test.cc@407 PS2, Line 407: txn_initiator(kNumTransactions, &txn_ids); > nit: not that we expect concurrency issues here, but maybe also dedupe thes Good point! Done. I added a check for the monotonicity of txn_ids. http://gerrit.cloudera.org:8080/#/c/16586/2/src/kudu/master/txn_manager.cc File src/kudu/master/txn_manager.cc: http://gerrit.cloudera.org:8080/#/c/16586/2/src/kudu/master/txn_manager.cc@123 PS2, Line 123: while (true) { > nit: should we DCHECK that highest_seen_txn_id >= 0 here too? Done -- To view, visit http://gerrit.cloudera.org:8080/16586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51c476d92bb5b147ffd03fd9f3163ab86d581496 Gerrit-Change-Number: 16586 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 14 Oct 2020 06:08:23 +0000 Gerrit-HasComments: Yes
