Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16586 )
Change subject: KUDU-2612: add TxnManager::BeginTransaction() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16586/3/src/kudu/master/txn_manager.cc File src/kudu/master/txn_manager.cc: http://gerrit.cloudera.org:8080/#/c/16586/3/src/kudu/master/txn_manager.cc@184 PS3, Line 184: try_txn_id / txn_status_table_range_span_) * : txn_status_table_range_span_; : const auto hb = lb + txn_status_table_range_span_; I'm not sure I see how this works if txn_status_table_range_span_ is different from FLAGS_txn_manager_status_table_range_partition_span. It's not listed as runtime, but isn't it possible that it's changed? -- To view, visit http://gerrit.cloudera.org:8080/16586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51c476d92bb5b147ffd03fd9f3163ab86d581496 Gerrit-Change-Number: 16586 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 14 Oct 2020 17:58:50 +0000 Gerrit-HasComments: Yes
