Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 )
Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc File src/kudu/transactions/coordinator_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc@188 PS2, Line 188: if (result.status.IsAborted()) { Should we also be handling IllegalState? E.g. if we change leaders as we are writing and fail in CheckLeadershipAndBindTerm? http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc@194 PS2, Line 194: TABLET_NOT_FOUND nit: maybe move this comment down by TABLET_NOT_FOUND? -- To view, visit http://gerrit.cloudera.org:8080/16815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59 Gerrit-Change-Number: 16815 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 07 Dec 2020 06:52:56 +0000 Gerrit-HasComments: Yes