Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 )
Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc File src/kudu/transactions/coordinator_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc@188 PS2, Line 188: if (result.status.IsAborted()) { > +1 I guess that was supposed to be handled in the code below with TabletServerErrorPB::NOT_THE_LEADER. Handling IllegalState() was a major point of pain here because TxnStatusManager returns IllegalState() if transaction is not in right state, and just assume that that's the leader change is not correct. It seems I need to clarify on this: probably, that means we'll need to introduce error codes specific to TxnStatusManager interface. -- To view, visit http://gerrit.cloudera.org:8080/16815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59 Gerrit-Change-Number: 16815 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Dec 2020 02:59:58 +0000 Gerrit-HasComments: Yes