Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 )
Change subject: tablet: allow interleaving of row liveness between compaction input rows ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16752/4/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/16752/4/src/kudu/tablet/compaction-test.cc@1109 PS4, Line 1109: TestRowHistoryJumpsBetweenRowsets2 Isn't this some sort of "sub-set" of TestRowHistoryJumpsBetweenRowsets? I'm not sure I understand why it's important to have this one as well if TestRowHistoryJumpsBetweenRowsets exists? Could you add more colors to describe why it's important to have both? -- To view, visit http://gerrit.cloudera.org:8080/16752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042a7d70d32edf9d2a3a077790821893f162880a Gerrit-Change-Number: 16752 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 12 Dec 2020 05:38:15 +0000 Gerrit-HasComments: Yes
