Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 )
Change subject: tablet: allow interleaving of row liveness between compaction input rows ...................................................................... Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16752/8/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/16752/8/src/kudu/tablet/compaction.cc@369 PS8, Line 369: if (PREDICT_TRUE(FLAGS_dcheck_on_kudu_2233_invariants)) { nit: if this validation is empty in NDEBUG case, maybe put the whole 'if()' clause under '#ifndef NDEBUG' then? -- To view, visit http://gerrit.cloudera.org:8080/16752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042a7d70d32edf9d2a3a077790821893f162880a Gerrit-Change-Number: 16752 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 24 Feb 2021 21:48:02 +0000 Gerrit-HasComments: Yes
