Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16887 )
Change subject: [java] allow disabling TLS transportation from java client ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@102 PS3, Line 102: String disableKuduClientTlsStr = System.getenv("DISABLE_KUDU_CLIENT_TLS"); Perhaps it's worth moving the methods in the reporter to a utility class for re-use here: https://github.com/apache/kudu/blob/cece57bcdf5d8d8ce596a3c1da4c2c26472784bc/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java#L139-L162 http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@260 PS3, Line 260: builder.addSupportedFeatures(RpcFeatureFlag.TLS_AUTHENTICATION_ONLY); Perhaps instead of disabling TLS all together we could use TLS_AUTHENTICATION_ONLY similar to loopback connections? -- To view, visit http://gerrit.cloudera.org:8080/16887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I762b9d6ef9257a7853684dd0aef315e5c5bba8ed Gerrit-Change-Number: 16887 Gerrit-PatchSet: 3 Gerrit-Owner: wangning <1994wangn...@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 22 Dec 2020 19:57:08 +0000 Gerrit-HasComments: Yes
