Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16887 )
Change subject: [java] allow disabling TLS transportation from java client ...................................................................... Patch Set 5: Code-Review-1 This is a nice feature, but right now we don't use many environment variables, especially on the client-side. I was also thinking about adding a similar config to *require* TLS as right now it's trivial to MITM and downgrade to clear text. If we used env vars, these two vars would collide. For these reasons, I'd rather we used code config which is a lot more robust and I feel like it's more widespread in the Java world. Env vars can still be added on the application-side if a user decides they want to control this behavior by env vars, but it's also possible to read the config from an XML or YAML config file as well if we opt to use code-configs. I realize this patch might not be the best place to discuss this, so maybe we should bring this up on dev@ instead. In the meantime, I'd recommend against merging this so I'm voting -1. -- To view, visit http://gerrit.cloudera.org:8080/16887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I762b9d6ef9257a7853684dd0aef315e5c5bba8ed Gerrit-Change-Number: 16887 Gerrit-PatchSet: 5 Gerrit-Owner: wangning <1994wangn...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <1994wangn...@gmail.com> Gerrit-Comment-Date: Mon, 11 Jan 2021 14:05:06 +0000 Gerrit-HasComments: No
