Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 )
Change subject: [build] Automate using GCC-8 on SLES 12 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" Just to make sure: we don't want to handle the case case if CC is set but CXX isn't, right? I guess such environment may bring some inconsistent result down the road, but I guess this script isn't the place to handle that anyways. http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 nit: may it be a case when /usr/bin/gcc-8 isn't available? Should we bail early (i.e. right here) in such case? -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 17:55:00 +0000 Gerrit-HasComments: Yes
