Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 )
Change subject: [build] Automate using GCC-8 on SLES 12 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" > I thought about this but chose to match the existing behavior and expect th yep, this makes sense to me http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 > I was on the fence about it. We can definitely do that in a follow up and t ack -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 18:45:23 +0000 Gerrit-HasComments: Yes
