Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 )
Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/16830/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16830/6//COMMIT_MSG@26 PS6, Line 26: If not, : above steps will have to be repeated. > I see. It probably makes sense to build this verification into a small tool CLI tool to add master that invokes ChangeConfig can definitely include this verification step. http://gerrit.cloudera.org:8080/#/c/16830/7/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16830/7/src/kudu/master/dynamic_multi_master-test.cc@173 PS7, Line 173: int64_t updated_gc_count; : while (MonoTime::Now() < deadline) { : updated_gc_count = get_sys_catalog_wal_gc_count(); : if (updated_gc_count > orig_gc_count) { : break; : } > Could we check this metric before creating each table? Then we wouldn't nee Done -- To view, visit http://gerrit.cloudera.org:8080/16830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142c1dec442ec72c38c5be9d62cdf270e441d6e3 Gerrit-Change-Number: 16830 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 17:55:16 +0000 Gerrit-HasComments: Yes
