Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16830 )
Change subject: [master] KUDU-2181 Procedure for copying sys catalog on adding master ...................................................................... Patch Set 9: (1 comment) Typically we reserve carrying forward +2s if there are no meaningful changes in the diff (e.g. if it's just a rebase), in case the diff get comments. Since this was already merged, feel free to ignore; I don't expect the extra check costs too much. http://gerrit.cloudera.org:8080/#/c/16830/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16830/9/src/kudu/master/dynamic_multi_master-test.cc@172 PS9, Line 172: break nit: we should be able to return here, rather than checking again below -- To view, visit http://gerrit.cloudera.org:8080/16830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I142c1dec442ec72c38c5be9d62cdf270e441d6e3 Gerrit-Change-Number: 16830 Gerrit-PatchSet: 9 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 07 Jan 2021 18:41:06 +0000 Gerrit-HasComments: Yes
