Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16937 )
Change subject: [util] extra test for MaintenanceManager ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc@748 PS1, Line 748: MonoDelta::FromMilliseconds(i % 8 + 1) Is this longer sleep time important if the goal of the test is to test for when the stats computation is slow? http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc@749 PS1, Line 749: MonoDelta::FromMicroseconds(5) >From the results in the commit message, there wasn't a big difference in this >reported timings. I'm curious whether you experimented with larger values, >especially given the issue at hand stems from larger update stats times from >computing the best compaction. -- To view, visit http://gerrit.cloudera.org:8080/16937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e71b213583c000d4809dcfc885c1d31b3bb9d5 Gerrit-Change-Number: 16937 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 11 Jan 2021 08:48:43 +0000 Gerrit-HasComments: Yes
