Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16937 )
Change subject: [util] extra test for MaintenanceManager ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc@748 PS1, Line 748: MonoDelta::FromMilliseconds(i % 8 + 1) > Is this longer sleep time important if the goal of the test is to test for I guess it is somewhat important to maintain proper relationship between duration of FindBestOp() and time when maintenance threads are ready to pickup a new task. The idea is to try hitting the spot when the FindBestOp() is still running, but some threads are done with their assignments from prior iteration. I'm not sure these timings are very precise, but at least the scheduler-related metrics show significant improvement after 9e4664d44ca994484d79d970e7c7e929d0dba055. http://gerrit.cloudera.org:8080/#/c/16937/1/src/kudu/util/maintenance_manager-test.cc@749 PS1, Line 749: MonoDelta::FromMicroseconds(5) > From the results in the commit message, there wasn't a big difference in th Nope, I didn't see much variance in the relative terms there (in absolute terms there were some, yes). I'm not quite sure I'm hitting the case like in the captured stack traces with this scenario. Rather, this scenario shows very good improvement in the scheduler-related perf metrics. I'm open to considering other scenarios, but playing with this one didn't give me an assurance that I reproduced the issue as shown in the captured stack traces in the commit message for 9e4664d44ca994484d79d970e7c7e929d0dba055 -- To view, visit http://gerrit.cloudera.org:8080/16937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e71b213583c000d4809dcfc885c1d31b3bb9d5 Gerrit-Change-Number: 16937 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 12 Jan 2021 09:15:27 +0000 Gerrit-HasComments: Yes
