Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17267 )
Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/master/dynamic_multi_master-test.cc@337 PS1, Line 337: new_master_out->swap(master) > Nit: std::move() might be better. Done http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/master/dynamic_multi_master-test.cc@513 PS1, Line 513: FLAGS_fs_wal_dir = fs_wal_dir; > Save and restore these flags. Done http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/master/dynamic_multi_master-test.cc@803 PS1, Line 803: auto opts = BuildMasterOpts(0, hp); : Status s = AddMasterToClusterUsingCLITool(opts, &err); > Nit: Combine these lines. Done http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/tools/tool_action_common.cc@767 PS1, Line 767: > Nit: Indentation Done http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17267/1/src/kudu/tools/tool_action_master.cc@191 PS1, Line 191: string fs_wal_dir; > Unused variable Done -- To view, visit http://gerrit.cloudera.org:8080/17267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f99cf2b3f1738c4127c7e7288beab61daf42e7b Gerrit-Change-Number: 17267 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Apr 2021 16:02:40 +0000 Gerrit-HasComments: Yes
